[JIRA] (SLF4J-371) Support the lambda expression in the Logger

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[JIRA] (SLF4J-371) Support the lambda expression in the Logger

JIRA noreply-jira@qos.ch

    [ https://jira.qos.ch/browse/SLF4J-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18763#comment-18763 ]

Mariano Ruiz commented on SLF4J-371:
------------------------------------

I agree with @HermanBovens that would be better support the same API than _Log4j2_.

> Support the lambda expression in the Logger
> -------------------------------------------
>
>                 Key: SLF4J-371
>                 URL: https://jira.qos.ch/browse/SLF4J-371
>             Project: SLF4J
>          Issue Type: Improvement
>          Components: Core API
>    Affects Versions: 1.7.22
>            Reporter: MiNG
>            Assignee: SLF4J developers list
>
> In some cases, we don't want to calculate the expression for logging eagerly cause the performance reason. Then, we would write the code like the following:
> ```
>     if (LOGGER.isWarnEnabled())
>     {
>        LOGGER.warn("some message: {}", Json.serialize(obj));
>     }
> ```
> Before JDK8, there is no way to encapsulate the above code, because the expression is always calculated before passed as an argument. So, many "if"s appear in the code and smell badly.
> Now, the lambda expression is supported by JDK8, the above could be simplified like following:
> ```
>     LOGGER.warn(formatter -> formatter.format("some message: {}", Json.serialize(obj)));
> ```
> With the default method definition in the org.slf4j.Logger:
> ```
>     public interface Logger
>     {
>       default void warn(Function<MessageFormatter, String> messageSupplier)
>       {
>         if (this.isWarnEnabled())
>         {
>           /* Calculate the expression only if the WARN level logging is enabled. */
>           this.warn(messageSupplier.apply(this.getFormatter()));
>         }
>       }
>     }
> ```



--
This message was sent by Atlassian JIRA
(v7.3.1#73012)
_______________________________________________
slf4j-dev mailing list
[hidden email]
http://mailman.qos.ch/mailman/listinfo/slf4j-dev
Loading...